chrome/browser/extensions/web_contents_browsertest.cc - Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/web_contents_browsertest.cc

Issue 11728003: Change ExecuteJavaScript* helper functions in browser_test_utils.{h,cc} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adding files for gpu_tests and NaCl browser tests. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/subscribe_page_action_browsertest.cc ('k') | chrome/browser/extensions/web_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/web_contents_browsertest.cc

diff --git a/chrome/browser/extensions/web_contents_browsertest.cc b/chrome/browser/extensions/web_contents_browsertest.cc

index 87d6cf8f231d86f0dafe3375492544ad46b2adca..04b4357ca2fb7c784e93516c7ae416168340d5eb 100644

--- a/chrome/browser/extensions/web_contents_browsertest.cc

+++ b/chrome/browser/extensions/web_contents_browsertest.cc

@@ -22,8 +22,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WebContents) {

bool result = false;

ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(

- chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",

- L"testTabsAPI()", &result));

+ chrome::GetActiveWebContents(browser())->GetRenderViewHost(),

+ "",

+ "testTabsAPI()",

+ &result));

EXPECT_TRUE(result);

// There was a bug where we would crash if we navigated to a page in the same

@@ -34,7 +36,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WebContents) {

GURL("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/page.html"));

result = false;