Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed)

Created:
8 years, 2 months ago by nduca

Modified:
8 years, 2 months ago

Reviewers:
dtu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chrome_remote_control] Add pylint to PRESUMMIT and fix lint R=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158719

Patch Set 1 #

Patch Set 2 : now the tests pass #

Patch Set 3 : for landing #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -159 lines)			Patch
A +	tools/chrome_remote_control/PRESUBMIT.py	View		1 chunk	+17 lines, -9 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/__init__.py	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/adb_commands.py	View	1 2	5 chunks	+17 lines, -14 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/browser_backend.py	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/browser_finder.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/browser_options.py	View	1 2	3 chunks	+10 lines, -9 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/browser_options_unittest.py	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py	View		3 chunks	+6 lines, -16 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/cros_browser_finder.py	View		3 chunks	+8 lines, -12 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/cros_interface.py	View	1 2	11 chunks	+27 lines, -23 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder_unittest.py	View		3 chunks	+10 lines, -8 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/inspector_backend.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/inspector_runtime.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest.py	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/page_runner.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/page_set.py	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/page_test.py	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/run_tests.py	View		5 chunks	+9 lines, -8 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/system_stub.py	View		3 chunks	+4 lines, -6 lines	0 comments	Download
M	tools/chrome_remote_control/chrome_remote_control/websocket.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/chrome_remote_control/examples/rendering_microbenchmark_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nduca

Some test failures, so dont cq yet. We need to get the tests running on ...

8 years, 2 months ago (2012-09-25 06:53:59 UTC) #1

lgtm

Expand Messages | Collapse Messages