tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/inspector_runtime.py ('k') | tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

index 8d5d74ff38fe08e1459bfb0468e5aca51b88e9af..42672628dffc249d5d8dd6a177060bc3d7be22d3 100644

--- a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

+++ b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py

@@ -5,14 +5,12 @@ import csv

import logging

import os

import sys

-import traceback

from chrome_remote_control import browser_finder

from chrome_remote_control import browser_options

from chrome_remote_control import page_runner

from chrome_remote_control import page_set

from chrome_remote_control import page_test

-from chrome_remote_control import util

class MeasurementFailure(page_test.Failure):

"""Exception that can be thrown from MeasurePage to indicate an undesired but

@@ -127,7 +125,7 @@ def Main(benchmark, args=None):

if len(args) != 1:

parser.print_usage()

- import page_sets

+ import page_sets # pylint: disable=F0401

sys.stderr.write('Available pagesets:\n%s\n\n' % ',\n'.join(

[os.path.relpath(f) for f in page_sets.GetAllPageSetFilenames()]))

sys.exit(1)