Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: tools/chrome_remote_control/chrome_remote_control/page_runner.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import logging 4 import logging
5 import os 5 import os
6 import time 6 import time
7 import traceback 7 import traceback
8 import urlparse 8 import urlparse
9 9
10 from chrome_remote_control import page_test 10 from chrome_remote_control import page_test
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 def Close(self): 63 def Close(self):
64 if self._server: 64 if self._server:
65 self._server.Close() 65 self._server.Close()
66 self._server = None 66 self._server = None
67 67
68 def PreparePage(self, page, tab): 68 def PreparePage(self, page, tab):
69 parsed_url = urlparse.urlparse(page.url) 69 parsed_url = urlparse.urlparse(page.url)
70 if parsed_url[0] == 'file': 70 if parsed_url[0] == 'file':
71 path = os.path.join(os.path.dirname(self.page_set.file_path), 71 path = os.path.join(os.path.dirname(self.page_set.file_path),
72 parsed_url[1]) 72 parsed_url.netloc) # pylint: disable=E1101
73 dirname, filename = os.path.split(path) 73 dirname, filename = os.path.split(path)
74 if self._server and self._server.path != dirname: 74 if self._server and self._server.path != dirname:
75 self._server.Close() 75 self._server.Close()
76 self._server = None 76 self._server = None
77 if not self._server: 77 if not self._server:
78 self._server = tab.browser.CreateTemporaryHTTPServer(dirname) 78 self._server = tab.browser.CreateTemporaryHTTPServer(dirname)
79 page.url = self._server.UrlOf(filename) 79 page.url = self._server.UrlOf(filename)
80 80
81 tab.page.Navigate(page.url) 81 tab.page.Navigate(page.url)
82 # TODO(dtu): Detect HTTP redirects. 82 # TODO(dtu): Detect HTTP redirects.
83 if page.wait_time_after_navigate: 83 if page.wait_time_after_navigate:
84 # Wait for unpredictable redirects. 84 # Wait for unpredictable redirects.
85 time.sleep(page.wait_time_after_navigate) 85 time.sleep(page.wait_time_after_navigate)
86 tab.WaitForDocumentReadyStateToBeInteractiveOrBetter() 86 tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
87 87
88 def CleanUpPage(self): 88 def CleanUpPage(self):
89 pass 89 pass
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698