tools/chrome_remote_control/chrome_remote_control/page_runner.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/page_runner.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_remote_control/chrome_remote_control/page_runner.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/page_runner.py b/tools/chrome_remote_control/chrome_remote_control/page_runner.py

index 08f3226088ea9a494092ab265b0d9d0ec61975bf..a3344144d0432a76e6d3b23d3398ff58a2cf6b47 100644

--- a/tools/chrome_remote_control/chrome_remote_control/page_runner.py

+++ b/tools/chrome_remote_control/chrome_remote_control/page_runner.py

@@ -69,7 +69,7 @@ class PageRunner(object):

parsed_url = urlparse.urlparse(page.url)

if parsed_url[0] == 'file':

path = os.path.join(os.path.dirname(self.page_set.file_path),

- parsed_url[1])

+ parsed_url.netloc) # pylint: disable=E1101

dirname, filename = os.path.split(path)

if self._server and self._server.path != dirname:

self._server.Close()