Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Side by Side Diff: tools/chrome_remote_control/chrome_remote_control/browser_options_unittest.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import unittest 4 import unittest
5 5
6 from chrome_remote_control import browser_options 6 from chrome_remote_control import browser_options
7 7
8 class BrowserOptionsTest(unittest.TestCase): 8 class BrowserOptionsTest(unittest.TestCase):
9 def testDefaults(self): 9 def testDefaults(self):
10 options = browser_options.BrowserOptions() 10 options = browser_options.BrowserOptions()
11 parser = options.CreateParser() 11 parser = options.CreateParser()
12 parser.add_option('-x', action='store', default=3) 12 parser.add_option('-x', action='store', default=3)
13 parser.parse_args(['--browser', 'any']) 13 parser.parse_args(['--browser', 'any'])
14 self.assertEquals(options.x, 3) 14 self.assertEquals(options.x, 3) # pylint: disable=E1101
15 15
16 def testDefaultsPlusOverride(self): 16 def testDefaultsPlusOverride(self):
17 options = browser_options.BrowserOptions() 17 options = browser_options.BrowserOptions()
18 parser = options.CreateParser() 18 parser = options.CreateParser()
19 parser.add_option('-x', action='store', default=3) 19 parser.add_option('-x', action='store', default=3)
20 parser.parse_args(['--browser', 'any', '-x', 10]) 20 parser.parse_args(['--browser', 'any', '-x', 10])
21 self.assertEquals(options.x, 10) 21 self.assertEquals(options.x, 10) # pylint: disable=E1101
22 22
23 def testDefaultsDontClobberPresetValue(self): 23 def testDefaultsDontClobberPresetValue(self):
24 options = browser_options.BrowserOptions() 24 options = browser_options.BrowserOptions()
25 setattr(options, 'x', 7) 25 setattr(options, 'x', 7)
26 parser = options.CreateParser() 26 parser = options.CreateParser()
27 parser.add_option('-x', action='store', default=3) 27 parser.add_option('-x', action='store', default=3)
28 parser.parse_args(['--browser', 'any']) 28 parser.parse_args(['--browser', 'any'])
29 self.assertEquals(options.x, 7) 29 self.assertEquals(options.x, 7) # pylint: disable=E1101
30 30
31 def testCount0(self): 31 def testCount0(self):
32 options = browser_options.BrowserOptions() 32 options = browser_options.BrowserOptions()
33 parser = options.CreateParser() 33 parser = options.CreateParser()
34 parser.add_option('-x', action='count', dest='v') 34 parser.add_option('-x', action='count', dest='v')
35 parser.parse_args(['--browser', 'any']) 35 parser.parse_args(['--browser', 'any'])
36 self.assertEquals(options.v, None) 36 self.assertEquals(options.v, None) # pylint: disable=E1101
37 37
38 def testCount2(self): 38 def testCount2(self):
39 options = browser_options.BrowserOptions() 39 options = browser_options.BrowserOptions()
40 parser = options.CreateParser() 40 parser = options.CreateParser()
41 parser.add_option('-x', action='count', dest='v') 41 parser.add_option('-x', action='count', dest='v')
42 parser.parse_args(['--browser', 'any', '-xx']) 42 parser.parse_args(['--browser', 'any', '-xx'])
43 self.assertEquals(options.v, 2) 43 self.assertEquals(options.v, 2) # pylint: disable=E1101
44 44
45 def testOptparseMutabilityWhenSpecified(self): 45 def testOptparseMutabilityWhenSpecified(self):
46 options = browser_options.BrowserOptions() 46 options = browser_options.BrowserOptions()
47 parser = options.CreateParser() 47 parser = options.CreateParser()
48 parser.add_option('-x', dest='verbosity', action='store_true') 48 parser.add_option('-x', dest='verbosity', action='store_true')
49 options_ret, _ = parser.parse_args(['--browser', 'any', '-x']) 49 options_ret, _ = parser.parse_args(['--browser', 'any', '-x'])
50 self.assertEquals(options_ret, options) 50 self.assertEquals(options_ret, options)
51 self.assertTrue(options.verbosity) 51 self.assertTrue(options.verbosity)
52 52
53 def testOptparseMutabilityWhenNotSpecified(self): 53 def testOptparseMutabilityWhenNotSpecified(self):
54 options = browser_options.BrowserOptions() 54 options = browser_options.BrowserOptions()
55 55
56 parser = options.CreateParser() 56 parser = options.CreateParser()
57 parser.add_option('-x', dest='verbosity', action='store_true') 57 parser.add_option('-x', dest='verbosity', action='store_true')
58 options_ret, _ = parser.parse_args(['--browser', 'any']) 58 options_ret, _ = parser.parse_args(['--browser', 'any'])
59 self.assertEquals(options_ret, options) 59 self.assertEquals(options_ret, options)
60 self.assertFalse(options.verbosity) 60 self.assertFalse(options.verbosity)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698