tools/chrome_remote_control/chrome_remote_control/browser_backend.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/browser_backend.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py ('k') | tools/chrome_remote_control/chrome_remote_control/browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/browser_backend.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/browser_backend.py b/tools/chrome_remote_control/chrome_remote_control/browser_backend.py

index 7131d3546a9d6c9314f0edd2e12dc9f00dab2e80..40d2b22bc363b040e1209a1253c8da77233aad33 100644

--- a/tools/chrome_remote_control/chrome_remote_control/browser_backend.py

+++ b/tools/chrome_remote_control/chrome_remote_control/browser_backend.py

@@ -45,7 +45,10 @@ class BrowserBackend(object):

else:

req = urllib2.urlopen('http://localhost:%i/json' % self._port)

data = req.read()

- return json.loads(data)

+ all_contexts = json.loads(data)

+ tabs = [ctx for ctx in all_contexts

+ if not ctx['url'].startswith('chrome-extension://')]

+ return tabs

@property

def num_tabs(self):