Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for landing Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py
index e8658a570d543573d7e70c9969d050d2ddb731b5..d7d5eb6500473e21fb9dc2432a154e5a0c9a0e48 100644
--- a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py
+++ b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py
@@ -6,8 +6,8 @@ import unittest
from chrome_remote_control import android_browser_finder
from chrome_remote_control import browser_options
-
-from system_stub import *
+from chrome_remote_control.system_stub import PopenStub
+from chrome_remote_control.system_stub import SubprocessModuleStub
# adb not even found
# android_browser_finder not returning
@@ -36,13 +36,13 @@ class ADBCommandsModuleStub(object):
return ADBCommandsStub(self, device)
self.ADBCommands = ADBCommandsStubConstructor
- def IsAndroidSupported(self):
+ def IsAndroidSupported(self): # pylint: disable=R0201
return True
def GetAttachedDevices(self):
return self.attached_devices
- def HasForwarder(self, adb):
+ def HasForwarder(self, adb): # pylint: disable=W0613,R0201
return True
class AndroidBrowserFinderTest(unittest.TestCase):
@@ -50,7 +50,7 @@ class AndroidBrowserFinderTest(unittest.TestCase):
options = browser_options.BrowserOptions()
subprocess_stub = SubprocessModuleStub()
- def NoADB(*args, **kargs):
+ def NoADB(*args, **kargs): # pylint: disable=W0613
raise OSError('not found')
subprocess_stub.Popen_hook = NoADB
browsers = android_browser_finder.FindAllAvailableBrowsers(

Powered by Google App Engine
This is Rietveld 408576698