tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest.py ('k') | tools/chrome_remote_control/chrome_remote_control/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py

index c864aba2a69d7cb2364feaf7e03655b9853e22b0..02a36cc8c2f6517324d2bfcc09dc50ea7f8147ad 100644

--- a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py

+++ b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark_unittest_base.py

@@ -20,9 +20,12 @@ class MultiPageBenchmarkUnitTestBase(unittest.TestCase):

def CreatePageSetFromFileInUnittestDataDir(self, test_filename):

path = os.path.join(self.unittest_data_dir, test_filename)

self.assertTrue(os.path.exists(path))

- page = page_set.Page('file://%s' % path)

- ps = page_set.PageSet()

+ page = page_set.Page('file://%s' % test_filename)

+ ps = page_set.PageSet(description='',

+ file_path=os.path.join(self.unittest_data_dir,

+ 'test_pageset.json'))

ps.pages.append(page)

return ps