tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/adb_commands.py ('k') | tools/chrome_remote_control/chrome_remote_control/android_browser_finder_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

index eeb0e2aa319956ff807233edb6275b425ea66e09..926301165184a400f1d5a793720cae3ea0bf5702 100644

--- a/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

+++ b/tools/chrome_remote_control/chrome_remote_control/android_browser_finder.py

@@ -1,6 +1,8 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+"""Finds android browsers that can be controlled by chrome_remote_control."""

import os as real_os

import subprocess as real_subprocess

import logging

@@ -11,9 +13,6 @@ import chrome_remote_control.adb_commands as real_adb_commands

from chrome_remote_control import browser

from chrome_remote_control import possible_browser

-"""Finds android browsers that can be controlled by chrome_remote_control."""

ALL_BROWSER_TYPES = ','.join([

'android-content-shell',

'android-chrome',