tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py - Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py

Issue 10984018: [chrome_remote_control] Add pylint to PRESUMMIT and fix lint (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for landing Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/cros_interface.py ('k') | tools/chrome_remote_control/chrome_remote_control/desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py b/tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py

index 5abebbfc1e6d48d0ee7e5049fbc87dfff0c1bb9f..af9b1e987aeb90ca37a1572a343f9bc252789b3d 100644

--- a/tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py

+++ b/tools/chrome_remote_control/chrome_remote_control/cros_interface_unittest.py

@@ -7,9 +7,9 @@

# a bit.

import unittest

-import browser_options

-import cros_interface

-import run_tests

+from chrome_remote_control import browser_options

+from chrome_remote_control import cros_interface

+from chrome_remote_control import run_tests

class CrOSInterfaceTest(unittest.TestCase):

@run_tests.RequiresBrowserOfType('cros-chrome')

@@ -59,7 +59,7 @@ class CrOSInterfaceTest(unittest.TestCase):

self.assertFalse(cri.FileExistsOnDevice('/etc/sdlfsdjflskfjsflj'))

@run_tests.RequiresBrowserOfType('cros-chrome')

- def testGetFileContents(self):

+ def testGetFileContents(self): # pylint: disable=R0201

remote = browser_options.options_for_unittests.cros_remote

cri = cros_interface.CrOSInterface(remote)

hosts = cri.GetFileContents('/etc/hosts')

@@ -74,13 +74,13 @@ class CrOSInterfaceTest(unittest.TestCase):

lambda: cri.GetFileContents('/tmp/209fuslfskjf/dfsfsf'))

@run_tests.RequiresBrowserOfType('cros-chrome')

- def testListProcesses(self):

+ def testListProcesses(self): # pylint: disable=R0201

remote = browser_options.options_for_unittests.cros_remote

cri = cros_interface.CrOSInterface(remote)

with cros_interface.DeviceSideProcess(

cri,

- ['sleep', '11']) as sleep:

+ ['sleep', '11']):

procs = cri.ListProcesses()

sleeps = [x for x in procs

if x[1] == 'sleep 11']