Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed)

Created:
8 years, 4 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, jeremya+watch_chromium.org, gideonwald, dcheng, Dmitry Titov, jennb, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, Shishir, cbentzel+watch_chromium.org, dominich, brettw-cc_chromium.org, gbillock+watch_chromium.org, Avi (use Gerrit), groby+watch_chromium.org, creis+watch_chromium.org, jianli, gavinp+prer_chromium.org, oshima+watch_chromium.org, Jered, mihaip-chromium-reviews_chromium.org, tfarina, sreeram, Aaron Boodman, dominich+watch_chromium.org, David Black, davemoore+watch_chromium.org, smckay+watch_chromium.org, mmenke
Visibility:
Public.

Description

Make TabContents ctor private; poke hole for existing callers. BUG=107201 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153527

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : all green #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -71 lines) Patch
M chrome/browser/chromeos/login/simple_web_view_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/web_auth_flow.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc View 1 2 7 chunks +36 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 6 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 1 4 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller_unittest.mm View 1 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/translate_infobar_unittest.mm View 1 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_backend_unittest.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 5 chunks +84 lines, -7 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/tab_contents/test_tab_contents.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 4 months ago (2012-08-24 20:22:03 UTC) #1
jam
lgtm
8 years, 3 months ago (2012-08-27 17:31:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10868072/1029
8 years, 3 months ago (2012-08-27 17:49:20 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 20:09:44 UTC) #4 
Change committed as 153527

Powered by Google App Engine
This is Rietveld 408576698