chrome/browser/ui/browser.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 329317b429d638a848f129ae777e08d39ed09ab2..5f0fbf6e6b87c6ebf3c8b7e55668596708c29481 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1516,7 +1516,7 @@ void Browser::WebContentsCreated(WebContents* source_contents,

// will later be inserted into this browser using Browser::Navigate via

// AddNewContents. The latter will retrieve the newly created TabContents from

// WebContents object.

- new TabContents(new_contents);

+ TabContents::Factory::CreateTabContents(new_contents);

// Notify.

RetargetingDetails details;