chrome/browser/instant/instant_loader.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_loader.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/instant/instant_loader.cc

diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc

index bc89c085ebc4dfc4eaa663a7b308dafd660bcfa8..aac948bd222cd1af46af715770f0aa62250084e7 100644

--- a/chrome/browser/instant/instant_loader.cc

+++ b/chrome/browser/instant/instant_loader.cc

@@ -264,10 +264,11 @@ InstantLoader::InstantLoader(InstantLoaderDelegate* delegate,

const TabContents* tab_contents)

: loader_delegate_(delegate),

preview_contents_(

- new TabContents(content::WebContents::CreateWithSessionStorage(

- tab_contents->profile(), NULL, MSG_ROUTING_NONE,

- tab_contents->web_contents(),

- tab_contents->web_contents()->GetController().

+ TabContents::Factory::CreateTabContents(

+ content::WebContents::CreateWithSessionStorage(

+ tab_contents->profile(), NULL, MSG_ROUTING_NONE,

+ tab_contents->web_contents(),

+ tab_contents->web_contents()->GetController().

GetSessionStorageNamespaceMap()))),

supports_instant_(false),

instant_url_(instant_url) {