Make TabContents ctor private; poke hole for existing callers.

chrome/browser/ui/tab_contents/tab_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/web_contents_observer.h"
 
 class AlternateErrorPageTabObserver;
 class AutocompleteHistoryManager;
 class AutofillManager;
 class AutofillExternalDelegate;
 class AutomationTabHelper;
+class BasePanelBrowserTest;
 class BlockedContentTabHelper;
 class BookmarkTabHelper;
+class Browser;
+class BrowserCommandsTabContentsCreator;
+class BrowserLauncherItemControllerContentsCreator;
+class BrowserTabstripTabContentsCreator;
+class ChromeWebContentsHandler;
+class ConstrainedWebDialogDelegateBase;
 class ConstrainedWindowTabHelper;
 class CoreTabHelper;
+class ExtensionTabUtil;
 class ExternalProtocolObserver;
+class ExternalTabContainerWin;
 class FaviconTabHelper;
+class FindBackendTestContentsCreator;
 class FindTabHelper;
+class GeolocationPermissionContextTests;
 class HistoryTabHelper;
 class HungPluginTabHelper;
+class InfoBarControllerContentsCreator;
 class InfoBarTabHelper;
+class InstantLoader;
 class MetroPinTabHelper;
 class NavigationMetricsRecorder;
+class OffscreenTabContentsCreator;
+class OldBasePanelBrowserTest;
 class OmniboxSearchHint;
 class PasswordManager;
 class PasswordManagerDelegate;
 class PDFTabObserver;
 class PluginObserver;
 class PrefsTabHelper;
 class Profile;
 class RestoreTabHelper;
 class SadTabHelper;
 class SearchEngineTabHelper;
+class ShellWindow;
 class SnapshotTabHelper;
 class TabContentsSSLHelper;
+class TabContentsTestHarness;
 class TabSpecificContentSettings;
+class TabStripModel;
+class TabStripModelContentsCreator;
 class ThumbnailGenerator;
 class TranslateTabHelper;
+class TranslationInfoBarTestContentsCreator;
+class WebDialogGtk;
+class WebDialogWindowControllerTabContentsCreator;
+class WebIntentInlineDispositionBrowserTest;
+class WebIntentPickerCocoa;
 class WebIntentPickerController;
+class WebIntentPickerGtk;
+class WebUITestContentsCreator;
 class ZoomController;
 
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
 class OneClickSigninHelper;
 #endif
 
 namespace browser_sync {
 class SyncedTabDelegate;
 }
 
 namespace captive_portal {
 class CaptivePortalTabHelper;
 }
 
 namespace chrome {
 namespace search {
 class SearchTabHelper;
 }
 }
 
 namespace chrome_browser_net {
 class LoadTimeStatsTabHelper;
 }
 
+namespace chromeos {
+class SimpleWebViewDialog;
+class WebUILoginView;
+}
+
 namespace extensions {
 class TabHelper;
+class WebAuthFlow;
 class WebNavigationTabObserver;
 }
 
 namespace prerender {
+class PrerenderContents;
 class PrerenderTabHelper;
 }
 
 namespace printing {
 class PrintViewManager;
 class PrintPreviewMessageHandler;
 }
 
 namespace safe_browsing {
 class SafeBrowsingTabObserver;
 }
 
 // Wraps WebContents and all of its supporting objects in order to control
 // their ownership and lifetime.
 //
 // WARNING: Not every place where HTML can run has a TabContents. This class is
 // *only* used in a visible, actual, tab inside a browser. Examples of things
 // that do not have a TabContents include:
 // - Extension background pages and popup bubbles
 // - HTML notification bubbles
 // - Screensavers on Chrome OS
 // - Other random places we decide to display HTML over time
 //
 // Consider carefully whether your feature is something that makes sense only
 // when a tab is displayed, or could make sense in other cases we use HTML. It
 // may makes sense to push down into WebContents and make configurable, or at
 // least to make easy for other WebContents hosts to include and support.
 class TabContents : public content::WebContentsObserver {
  public:
-  // Takes ownership of |contents|, which must be heap-allocated (as it lives
-  // in a scoped_ptr) and can not be NULL.
-  explicit TabContents(content::WebContents* contents);
+  class Factory {
+   private:
+    // TabContents is going away <http://crbug.com/107201> so don't allow any
+    // more code to construct instances. Explicitly befriend those who currently
+    // do so.
+
+    friend class BasePanelBrowserTest;
+    friend class Browser;
+    friend class BrowserCommandsTabContentsCreator;
+    friend class BrowserLauncherItemControllerContentsCreator;
+    friend class BrowserTabstripTabContentsCreator;
+    friend class chromeos::SimpleWebViewDialog;
+    friend class chromeos::WebUILoginView;
+    friend class ChromeWebContentsHandler;
+    friend class ConstrainedWebDialogDelegateBase;
+    friend class extensions::WebAuthFlow;
+    friend class ExtensionTabUtil;
+    friend class ExternalTabContainerWin;
+    friend class FindBackendTestContentsCreator;
+    friend class GeolocationPermissionContextTests;
+    friend class InfoBarControllerContentsCreator;
+    friend class InstantLoader;
+    friend class OldBasePanelBrowserTest;
+    friend class OffscreenTabContentsCreator;
+    friend class prerender::PrerenderContents;
+    friend class ShellWindow;
+    friend class TabContentsTestHarness;
+    friend class TabStripModel;
+    friend class TabStripModelContentsCreator;
+    friend class TranslationInfoBarTestContentsCreator;
+    friend class WebDialogGtk;
+    friend class WebDialogWindowControllerTabContentsCreator;
+    friend class WebIntentInlineDispositionBrowserTest;
+    friend class WebIntentPickerCocoa;
+    friend class WebIntentPickerGtk;
+    friend class WebUITestContentsCreator;
+
+    static TabContents* CreateTabContents(content::WebContents* contents);
+    static TabContents* CloneTabContents(TabContents* contents);
+  };
+
   virtual ~TabContents();
 
-  // Create a TabContents with the same state as this one. The returned
-  // heap-allocated pointer is owned by the caller.
-  TabContents* Clone();
-
   // Helper to retrieve the existing instance that owns a given WebContents.
   // Returns NULL if there is no such existing instance.
   // NOTE: This is not intended for general use. It is intended for situations
   // like callbacks from content/ where only a WebContents is available. In the
   // general case, please do NOT use this; plumb TabContents through the chrome/
   // code instead of WebContents.
   static TabContents* FromWebContents(content::WebContents* contents);
   static const TabContents* FromWebContents(
       const content::WebContents* contents);
 
@@ skipping 125 matching lines @@
     return zoom_controller_.get();
   }
 
   // Overrides -----------------------------------------------------------------
 
   // content::WebContentsObserver overrides:
   virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;
   virtual void UserAgentOverrideSet(const std::string& user_agent) OVERRIDE;
 
  private:
+  friend class TabContentsFactory;
+
+  // Takes ownership of |contents|, which must be heap-allocated (as it lives
+  // in a scoped_ptr) and can not be NULL.
+  explicit TabContents(content::WebContents* contents);
+
+  // Create a TabContents with the same state as this one. The returned
+  // heap-allocated pointer is owned by the caller.
+  TabContents* Clone();
+
   // Tab Helpers ---------------------------------------------------------------
   // (These provide API for callers and have a getter function listed in the
   // "Tab Helpers" section in the member functions area, above.)
 
   scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
   scoped_refptr<AutofillManager> autofill_manager_;
   scoped_ptr<AutofillExternalDelegate> autofill_external_delegate_;
   scoped_ptr<AutomationTabHelper> automation_tab_helper_;
   scoped_ptr<BlockedContentTabHelper> blocked_content_tab_helper_;
   scoped_ptr<BookmarkTabHelper> bookmark_tab_helper_;
@@ skipping 68 matching lines @@
 
   // The supporting objects need to outlive the WebContents dtor (as they may
   // be called upon during its execution). As a result, this must come last
   // in the list.
   scoped_ptr<content::WebContents> web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContents);
 };
 
 #endif  // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_