chrome/browser/extensions/api/identity/web_auth_flow.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/web_auth_flow.cc

diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.cc b/chrome/browser/extensions/api/identity/web_auth_flow.cc

index c016fca73780a2da707180b1168c9e43dc37268e..e5f37d0e76bef9dfb1eb3dbd67f99e6d4c4b2724 100644

--- a/chrome/browser/extensions/api/identity/web_auth_flow.cc

+++ b/chrome/browser/extensions/api/identity/web_auth_flow.cc

@@ -108,7 +108,7 @@ WebContents* WebAuthFlow::CreateWebContents() {

void WebAuthFlow::ShowAuthFlowPopup() {

// Pass ownership of WebContents to TabContents.

- tab_contents_ = new TabContents(contents_);

+ tab_contents_ = TabContents::Factory::CreateTabContents(contents_);

contents_ = NULL;

Browser* browser = new Browser(Browser::CreateParams(

Browser::TYPE_POPUP, profile_));