chrome/browser/ui/gtk/web_intent_picker_gtk.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/web_intent_picker_gtk.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/web_intent_picker_gtk.cc

diff --git a/chrome/browser/ui/gtk/web_intent_picker_gtk.cc b/chrome/browser/ui/gtk/web_intent_picker_gtk.cc

index 000cd0e419c5ebcbfd99ab310ada28a30da62687..e6d579d3172bf66d7bda2752cd886c3be1420c2c 100644

--- a/chrome/browser/ui/gtk/web_intent_picker_gtk.cc

+++ b/chrome/browser/ui/gtk/web_intent_picker_gtk.cc

@@ -287,7 +287,8 @@ void WebIntentPickerGtk::OnInlineDisposition(const string16& title,

tab_contents_->profile(),

tab_util::GetSiteInstanceForNewTab(tab_contents_->profile(), url),

MSG_ROUTING_NONE, NULL);

- inline_disposition_tab_contents_.reset(new TabContents(web_contents));

+ inline_disposition_tab_contents_.reset(

+ TabContents::Factory::CreateTabContents(web_contents));

Browser* browser = browser::FindBrowserWithWebContents(

tab_contents_->web_contents());

inline_disposition_delegate_.reset(