chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

index 4de47875373a9bb8ecf9939cb07a0b0acf56381a..ecd7a42f98d99dae2ba055a4ab80a91452621321 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

@@ -216,7 +216,7 @@ void GeolocationPermissionContextTests::AddNewTab(const GURL& url) {

url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());

RenderViewHostTester::For(new_tab->GetRenderViewHost())->

SendNavigate(extra_tabs_.size() + 1, url);

- extra_tabs_.push_back(new TabContents(new_tab));

+ extra_tabs_.push_back(TabContents::Factory::CreateTabContents(new_tab));

}

void GeolocationPermissionContextTests::CheckTabContentsState(

« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/instant/instant_loader.cc » ('j') | no next file with comments »