chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

index bfc97d76679d0137ee85b727d5b70dcea5c6984d..9be55dbe46a189708fceea3aaf24ff8305e93b39 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

+++ b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

@@ -33,7 +33,7 @@ ConstrainedWebDialogDelegateBase::ConstrainedWebDialogDelegateBase(

CHECK(delegate);

WebContents* web_contents =

WebContents::Create(profile, NULL, MSG_ROUTING_NONE, NULL);

- tab_.reset(new TabContents(web_contents));

+ tab_.reset(TabContents::Factory::CreateTabContents(web_contents));

if (tab_delegate) {

override_tab_delegate_.reset(tab_delegate);

web_contents->SetDelegate(tab_delegate);