chrome/browser/ui/extensions/shell_window.cc - Issue 10868072: Make TabContents ctor private; poke hole for existing callers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: all green Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/shell_window.cc

diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc

index d85c28fb15dd5f2383dd81a74453c8f075092ab9..da858acec0c294be43baf41133ee3a0245abfac7 100644

--- a/chrome/browser/ui/extensions/shell_window.cc

+++ b/chrome/browser/ui/extensions/shell_window.cc

@@ -91,7 +91,7 @@ void ShellWindow::Init(const GURL& url,

web_contents_ = WebContents::Create(

profile(), SiteInstance::CreateForURL(profile(), url), MSG_ROUTING_NONE,

NULL);

- contents_.reset(new TabContents(web_contents_));

+ contents_.reset(TabContents::Factory::CreateTabContents(web_contents_));

content::WebContentsObserver::Observe(web_contents_);

web_contents_->SetDelegate(this);

chrome::SetViewType(web_contents_, chrome::VIEW_TYPE_APP_SHELL);