Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8549)

Unified Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 10868072: Make TabContents ctor private; poke hole for existing callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: all green Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/external_tab_container_win.cc
diff --git a/chrome/browser/ui/views/external_tab_container_win.cc b/chrome/browser/ui/views/external_tab_container_win.cc
index 841baaafc0b6745e85b676f95c9ae5b648b2d993..32c5d1b5ecf7823047b7425948680a2d09beebfd 100644
--- a/chrome/browser/ui/views/external_tab_container_win.cc
+++ b/chrome/browser/ui/views/external_tab_container_win.cc
@@ -194,7 +194,7 @@ bool ExternalTabContainerWin::Init(Profile* profile,
} else {
WebContents* new_contents = WebContents::Create(
profile, NULL, MSG_ROUTING_NONE, NULL);
- tab_contents_.reset(new TabContents(new_contents));
+ tab_contents_.reset(TabContents::Factory::CreateTabContents(new_contents));
}
if (!infobars_enabled)
@@ -489,7 +489,8 @@ void ExternalTabContainerWin::AddNewContents(WebContents* source,
// Make sure that ExternalTabContainer instance is initialized with
// an unwrapped Profile.
- scoped_ptr<TabContents> tab_contents(new TabContents(new_contents));
+ scoped_ptr<TabContents> tab_contents(
+ TabContents::Factory::CreateTabContents(new_contents));
bool result = new_container->Init(
tab_contents->profile()->GetOriginalProfile(),
NULL,
« no previous file with comments | « chrome/browser/ui/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/webui/chrome_web_contents_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698