Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, akalin, tfarina, Aaron Boodman, Raghu Simha, chromium-apps-reviews_chromium.org, haitaol1, alicet1, markusheintz_, tim (not reviewing)
Visibility:
Public.

Description

Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. Removes the redundant/unnecessary helper function. Call Show() on GetWidget() or CreateBubble's returned Widget. BUG=none TEST=Bubbles show fine. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188557

Patch Set 1 #

Patch Set 2 : Fixup more BubbleDelegateView::Show() calls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -51 lines) Patch
M ash/launcher/launcher_tooltip_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/bubble.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/network/network_list_detailed_view_base.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_prompt_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/network_profile_bubble_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/message_center/views/message_center_bubble.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/bubble/bubble_frame_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/bubble_example.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_editing_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 9 months ago (2013-03-15 21:51:47 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-15 23:16:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12897004/10001
7 years, 9 months ago (2013-03-15 23:34:07 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-16 09:16:22 UTC) #4
Message was sent while issue was closed. 
Change committed as 188557

Powered by Google App Engine
This is Rietveld 408576698