chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.cc ('k') | chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

diff --git a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

index e51ca3b7d2a01eba24d9cafc4f5a3a27404c3ef3..dc3a00567b0b5eb86ff2ccdc5a8a87eab84fa16c 100644

--- a/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

+++ b/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc

@@ -53,7 +53,7 @@ void OpenPDFInReaderView::ShowBubble() {

bubble_ = new OpenPDFInReaderBubbleView(this, model_);

views::BubbleDelegateView::CreateBubble(bubble_);

bubble_->GetWidget()->AddObserver(this);

- bubble_->Show();

+ bubble_->GetWidget()->Show();

}

void OpenPDFInReaderView::GetAccessibleState(ui::AccessibleViewState* state) {