chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc ('k') | chrome/browser/ui/views/location_bar/zoom_bubble_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/location_bar/script_bubble_icon_view.h"	5 #include "chrome/browser/ui/views/location_bar/script_bubble_icon_view.h"

6	6

7 #include "base/strings/string_number_conversions.h"	7 #include "base/strings/string_number_conversions.h"

8 #include "chrome/browser/ui/view_ids.h"	8 #include "chrome/browser/ui/view_ids.h"

9 #include "chrome/browser/ui/views/script_bubble_view.h"	9 #include "chrome/browser/ui/views/script_bubble_view.h"

10 #include "chrome/common/extensions/api/extension_action/action_info.h"	10 #include "chrome/common/extensions/api/extension_action/action_info.h"

(...skipping 78 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
89 if (event->type() == ui::ET_GESTURE_TAP) {	89 if (event->type() == ui::ET_GESTURE_TAP) {

90 ShowScriptBubble(this, location_bar_delegate_->GetWebContents());	90 ShowScriptBubble(this, location_bar_delegate_->GetWebContents());

91 event->SetHandled();	91 event->SetHandled();

92 }	92 }

93 }	93 }

94	94

95 void ScriptBubbleIconView::ShowScriptBubble(views::View* anchor_view,	95 void ScriptBubbleIconView::ShowScriptBubble(views::View* anchor_view,

96 WebContents* web_contents) {	96 WebContents* web_contents) {

97 ScriptBubbleView* script_bubble = new ScriptBubbleView(anchor_view,	97 ScriptBubbleView* script_bubble = new ScriptBubbleView(anchor_view,

98 web_contents);	98 web_contents);

99 views::BubbleDelegateView::CreateBubble(script_bubble);	99 views::BubbleDelegateView::CreateBubble(script_bubble)->Show();

100 script_bubble->Show();

101 }	100 }

OLD	NEW