chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/speech_recognition_bubble_views.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index 9ff07089d80d32772ef9e26d0f08928f83ced220..d3a14cccb866347cc996b3f505e1db089e048aac 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -204,8 +204,7 @@ void OneClickSigninBubbleView::ShowBubble(

new OneClickSigninDialogView(toolbar_view->GetWebContents(),

toolbar_view->location_bar(), start_sync);

- views::BubbleDelegateView::CreateBubble(bubble_view_);

- bubble_view_->Show();

+ views::BubbleDelegateView::CreateBubble(bubble_view_)->Show();

}

// static