Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: chrome/browser/ui/views/network_profile_bubble_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/network_profile_bubble_view.h" 5 #include "chrome/browser/ui/views/network_profile_bubble_view.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/network_profile_bubble.h" 10 #include "chrome/browser/ui/network_profile_bubble.h"
(...skipping 18 matching lines...) Expand all
29 } // namespace 29 } // namespace
30 30
31 // static 31 // static
32 void NetworkProfileBubble::ShowNotification(Browser* browser) { 32 void NetworkProfileBubble::ShowNotification(Browser* browser) {
33 views::View* anchor = NULL; 33 views::View* anchor = NULL;
34 BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser); 34 BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
35 if (browser_view && browser_view->GetToolbarView()) 35 if (browser_view && browser_view->GetToolbarView())
36 anchor = browser_view->GetToolbarView()->app_menu(); 36 anchor = browser_view->GetToolbarView()->app_menu();
37 NetworkProfileBubbleView* bubble = 37 NetworkProfileBubbleView* bubble =
38 new NetworkProfileBubbleView(anchor, browser, browser->profile()); 38 new NetworkProfileBubbleView(anchor, browser, browser->profile());
39 views::BubbleDelegateView::CreateBubble(bubble); 39 views::BubbleDelegateView::CreateBubble(bubble)->Show();
40 bubble->Show();
41 NetworkProfileBubble::SetNotificationShown(true); 40 NetworkProfileBubble::SetNotificationShown(true);
42 41
43 // Mark the time of the last bubble and reduce the number of warnings left 42 // Mark the time of the last bubble and reduce the number of warnings left
44 // before the next silence period starts. 43 // before the next silence period starts.
45 PrefService* prefs = browser->profile()->GetPrefs(); 44 PrefService* prefs = browser->profile()->GetPrefs();
46 prefs->SetInt64(prefs::kNetworkProfileLastWarningTime, 45 prefs->SetInt64(prefs::kNetworkProfileLastWarningTime,
47 base::Time::Now().ToTimeT()); 46 base::Time::Now().ToTimeT());
48 int left_warnings = prefs->GetInteger(prefs::kNetworkProfileWarningsLeft); 47 int left_warnings = prefs->GetInteger(prefs::kNetworkProfileWarningsLeft);
49 if (left_warnings > 0) 48 if (left_warnings > 0)
50 prefs->SetInteger(prefs::kNetworkProfileWarningsLeft, --left_warnings); 49 prefs->SetInteger(prefs::kNetworkProfileWarningsLeft, --left_warnings);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 content::PAGE_TRANSITION_LINK, false); 131 content::PAGE_TRANSITION_LINK, false);
133 navigator_->OpenURL(params); 132 navigator_->OpenURL(params);
134 133
135 // If the user interacted with the bubble we don't reduce the number of 134 // If the user interacted with the bubble we don't reduce the number of
136 // warnings left. 135 // warnings left.
137 PrefService* prefs = profile_->GetPrefs(); 136 PrefService* prefs = profile_->GetPrefs();
138 int left_warnings = prefs->GetInteger(prefs::kNetworkProfileWarningsLeft); 137 int left_warnings = prefs->GetInteger(prefs::kNetworkProfileWarningsLeft);
139 prefs->SetInteger(prefs::kNetworkProfileWarningsLeft, ++left_warnings); 138 prefs->SetInteger(prefs::kNetworkProfileWarningsLeft, ++left_warnings);
140 GetWidget()->Close(); 139 GetWidget()->Close();
141 } 140 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/zoom_bubble_view.cc ('k') | chrome/browser/ui/views/speech_recognition_bubble_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698