ash/shell/bubble.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/shell/bubble.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « ash/launcher/launcher_tooltip_manager.cc ('k') | ash/system/chromeos/network/network_list_detailed_view_base.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/utf_string_conversions.h"	5 #include "base/utf_string_conversions.h"

6 #include "ui/views/bubble/bubble_border.h"	6 #include "ui/views/bubble/bubble_border.h"

7 #include "ui/views/bubble/bubble_delegate.h"	7 #include "ui/views/bubble/bubble_delegate.h"

8 #include "ui/views/controls/label.h"	8 #include "ui/views/controls/label.h"

9 #include "ui/views/layout/fill_layout.h"	9 #include "ui/views/layout/fill_layout.h"

10 #include "ui/views/widget/widget.h"	10 #include "ui/views/widget/widget.h"

(...skipping 22 matching lines...) Expand all Loading...
33 private:	33 private:

34 string16 label_;	34 string16 label_;

35 };	35 };

36	36

37 void CreatePointyBubble(views::View* anchor_view) {	37 void CreatePointyBubble(views::View* anchor_view) {

38 BubbleConfig config;	38 BubbleConfig config;

39 config.label = ASCIIToUTF16("PointyBubble");	39 config.label = ASCIIToUTF16("PointyBubble");

40 config.anchor_view = anchor_view;	40 config.anchor_view = anchor_view;

41 config.arrow = views::BubbleBorder::TOP_LEFT;	41 config.arrow = views::BubbleBorder::TOP_LEFT;

42 ExampleBubbleDelegateView* bubble = new ExampleBubbleDelegateView(config);	42 ExampleBubbleDelegateView* bubble = new ExampleBubbleDelegateView(config);

43 views::BubbleDelegateView::CreateBubble(bubble);	43 views::BubbleDelegateView::CreateBubble(bubble)->Show();

44 bubble->Show();

45 }	44 }

46	45

47 } // namespace shell	46 } // namespace shell

48 } // namespace ash	47 } // namespace ash

OLD	NEW