chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc ('k') | ui/message_center/views/message_center_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index 237b075140da33d6cc159627081dd3b0ff6e0bf2..ff81663184afbfa0139512ae95d76143041ac89f 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -240,8 +240,7 @@ InternalPageInfoPopupView::InternalPageInfoPopupView(views::View* anchor_view)

label->SetHorizontalAlignment(gfx::ALIGN_LEFT);

AddChildView(label);

- views::BubbleDelegateView::CreateBubble(this);

- Show();

+ views::BubbleDelegateView::CreateBubble(this)->Show();

SizeToContents();

}

@@ -334,8 +333,7 @@ WebsiteSettingsPopupView::WebsiteSettingsPopupView(

set_margins(gfx::Insets(kPopupMarginTop, kPopupMarginLeft,

kPopupMarginBottom, kPopupMarginRight));

- views::BubbleDelegateView::CreateBubble(this);

- this->Show();

+ views::BubbleDelegateView::CreateBubble(this)->Show();

SizeToContents();

TabSpecificContentSettings* content_settings =

« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc ('k') | ui/message_center/views/message_center_bubble.cc » ('j') | no next file with comments »