ash/system/chromeos/network/network_list_detailed_view_base.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/network/network_list_detailed_view_base.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/chromeos/network/network_list_detailed_view_base.cc

diff --git a/ash/system/chromeos/network/network_list_detailed_view_base.cc b/ash/system/chromeos/network/network_list_detailed_view_base.cc

index 0c8740de9e3c950bff021d150496dedd1f3aaf4c..34708beb2a8a56ee5f410391b69044cc8240fc8d 100644

--- a/ash/system/chromeos/network/network_list_detailed_view_base.cc

+++ b/ash/system/chromeos/network/network_list_detailed_view_base.cc

@@ -404,8 +404,7 @@ void NetworkListDetailedViewBase::ToggleInfoBubble() {

info_bubble_ = new NonActivatableSettingsBubble(

info_icon_, CreateNetworkInfoView());

- views::BubbleDelegateView::CreateBubble(info_bubble_);

- info_bubble_->Show();

+ views::BubbleDelegateView::CreateBubble(info_bubble_)->Show();

}

// Returns whether an existing info-bubble was closed.

« no previous file with comments | « ash/shell/bubble.cc ('k') | ash/system/chromeos/network/network_state_list_detailed_view.cc » ('j') | no next file with comments »