chrome/browser/ui/views/location_bar/content_setting_image_view.cc - Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.cc

Issue 12897004: Remove BubbleDelegateView::Show(); call GetWidget()->Show() instead; etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixup more BubbleDelegateView::Show() calls. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"	5 #include "chrome/browser/ui/views/location_bar/content_setting_image_view.h"

6	6

7 #include "base/utf_string_conversions.h"	7 #include "base/utf_string_conversions.h"

8 #include "chrome/browser/content_settings/tab_specific_content_settings.h"	8 #include "chrome/browser/content_settings/tab_specific_content_settings.h"

9 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"	9 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"

10 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"	10 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"

(...skipping 118 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129 ContentSettingBubbleModel::CreateContentSettingBubbleModel(	129 ContentSettingBubbleModel::CreateContentSettingBubbleModel(

130 parent->delegate()->GetContentSettingBubbleModelDelegate(),	130 parent->delegate()->GetContentSettingBubbleModelDelegate(),

131 web_contents,	131 web_contents,

132 profile,	132 profile,

133 content_setting_image_model_->get_content_settings_type()),	133 content_setting_image_model_->get_content_settings_type()),

134 web_contents,	134 web_contents,

135 this,	135 this,

136 views::BubbleBorder::TOP_RIGHT);	136 views::BubbleBorder::TOP_RIGHT);

137 bubble_widget_ = parent->delegate()->CreateViewsBubble(bubble);	137 bubble_widget_ = parent->delegate()->CreateViewsBubble(bubble);

138 bubble_widget_->AddObserver(this);	138 bubble_widget_->AddObserver(this);

139 bubble->Show();	139 bubble->GetWidget()->Show();

140 }	140 }

OLD	NEW