Make GLES2Implementation based on GLES2Interface

Make GLES2Implementation based on GLES2Interface

GLES2Interface is a pure virutal interface. It's likely
that more functions of GLES2Implementation will need have
be declared in GLES2Interface but this is a first step

BUG=155914
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162216

[greggman, 2012-10-15 20:08:21]

Hi Piman, James, PTAL

It seemed easist to declare GLES2Interface and make GLES2Implementation inherit
from that. Code that is currently using GLES2Implementation can then change as
needed.

[jamesr, 2012-10-15 20:16:16]

Antoine - I'd like to port cc/ over to depending on this instead of
WebGraphicsContext3D so we don't have to do miles of plumbing for every GL
extension and entry point we want to use in the compositor.

[greggman, 2012-10-15 20:31:35]

Hey James, Do you want me to auto-generate a gmock mock?

[jamesr, 2012-10-15 20:38:53]

On 2012/10/15 20:31:35, greggman wrote:
> Hey James, Do you want me to auto-generate a gmock mock?

Most of our GL mocks aren't actually gmock.  A stub implementation (all no-ops)
would be good but I wouldn't bother with a gmock mock.

[piman, 2012-10-16 02:53:17]

On 2012/10/15 20:16:16, jamesr wrote:
> Antoine - I'd like to port cc/ over to depending on this instead of
> WebGraphicsContext3D so we don't have to do miles of plumbing for every GL
> extension and entry point we want to use in the compositor.

I wholeheartedly support this endeavor.

We'll probably just need to fix our multiple implementations of WGC3D, replacing
them by a GLES2Interface implementation and have a single WGC3D wrapper that
takes a GLES2Interface (for WebKit proper)?

In any case, LGTM on this CL.

[commit-bot: I haz the power, 2012-10-16 16:16:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/11138021/3002

[commit-bot: I haz the power, 2012-10-16 16:16:54]

Presubmit check for 11138021-3002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/native_client

Presubmit checks took 2.7s to calculate.

[greggman, 2012-10-16 16:34:28]

Hey Bill, can you please take a look at the ppapi file changes?  thank you

[bbudge, 2012-10-16 16:38:15]

LGTM

[commit-bot: I haz the power, 2012-10-16 16:42:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/11138021/3002

[commit-bot: I haz the power, 2012-10-16 19:46:10]

Change committed as 162216