Chromium Code Reviews
Help | Chromium Project | Sign in
(34)

Issue 11040025: Revert r12646 "Support for SDIV" because of failing V8 benchmark. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by ulan
Modified:
2 years, 5 months ago
Reviewers:
subratokde, danno
CC:
v8-dev
Visibility:
Public.

Description

Revert r12646 "Support for SDIV" because of failing V8 benchmark. With r12646 V8 does not terminate on V8 Crypto benchmark. BUG=v8:2354 R=danno@chromium.org,subratokde@codeaurora.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -214 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +5 lines, -24 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +94 lines, -117 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +5 lines, -36 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/v8globals.h View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
ulan
PTAL
2 years, 5 months ago (2012-10-02 14:44:21 UTC) #1
ulan
2 years, 5 months ago (2012-10-02 16:01:03 UTC) #2
Abandoning this CL because of found fix:
https://chromiumcodereview.appspot.com/11038017
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted