Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed)

Created:
8 years, 3 months ago by Lei Zhang
Modified:
8 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, mihaip-chromium-reviews_chromium.org, Satish, jam, browser-components-watch_chromium.org, Aaron Boodman, groby+watch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, markusheintz_, James Su, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155073

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : rebase, remove a few more lines of code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -226 lines) Patch
M chrome/browser/autocomplete/autocomplete_classifier_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service_factory.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/background/background_contents_service_factory.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_model_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/cookie_settings.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/cookie_settings.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_factory.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_factory.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service_factory.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/discovery/suggested_links_registry_factory.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/discovery/suggested_links_registry_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 8 chunks +28 lines, -37 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/shell_window_registry.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/shell_window_registry.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_factory.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/google/google_url_tracker_factory.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_service_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/shortcuts_backend_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_backend_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/cws_intents_registry_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/cws_intents_registry_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/media_galleries_preferences_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/media_galleries_preferences_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugin_prefs.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/plugin_prefs_factory.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_prefs_factory.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/user_policy_signin_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/user_policy_signin_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_factory.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_link_manager_factory.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.h View 1 2 3 4 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_keyed_base_factory.cc View 1 2 3 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/protector/protector_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/protector/protector_service_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.cc View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/speech/speech_input_extension_manager.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/credential_cache_service_factory_win.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/credential_cache_service_factory_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_state_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_state_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gesture_prefs_observer_factory_aura.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/global_error/global_error_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/global_error/global_error_service_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/user_style_sheet_watcher_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/user_style_sheet_watcher_factory.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
chrome/browser/profiles/profile_keyed_base_factory.h is the only file worth looking at. Everything else is just cookie cutter search ...
8 years, 3 months ago (2012-09-05 04:22:43 UTC) #1
Lei Zhang
On 2012/09/05 04:22:43, Lei Zhang wrote: > chrome/browser/profiles/profile_keyed_base_factory.h is the only file worth > looking ...
8 years, 3 months ago (2012-09-05 08:31:37 UTC) #2
Elliot Glaysher
lgtm
8 years, 3 months ago (2012-09-05 16:51:31 UTC) #3
Lei Zhang
https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc File chrome/browser/extensions/extension_service_unittest.cc (right): https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc#newcode427 chrome/browser/extensions/extension_service_unittest.cc:427: ThemeServiceFactory::GetInstance()->RegisterUserPrefsOnProfile( It also occurred to me, we probably don't ...
8 years, 3 months ago (2012-09-05 19:16:26 UTC) #4
Elliot Glaysher
https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc File chrome/browser/extensions/extension_service_unittest.cc (right): https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc#newcode427 chrome/browser/extensions/extension_service_unittest.cc:427: ThemeServiceFactory::GetInstance()->RegisterUserPrefsOnProfile( On 2012/09/05 19:16:26, Lei Zhang wrote: > It ...
8 years, 3 months ago (2012-09-05 19:35:39 UTC) #5
Lei Zhang
On 2012/09/05 19:35:39, Elliot Glaysher wrote: > https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc > File chrome/browser/extensions/extension_service_unittest.cc (right): > > https://chromiumcodereview.appspot.com/10908088/diff/4024/chrome/browser/extensions/extension_service_unittest.cc#newcode427 ...
8 years, 3 months ago (2012-09-05 21:11:16 UTC) #6
Elliot Glaysher
On 2012/09/05 21:11:16, Lei Zhang wrote: > On 2012/09/05 19:35:39, Elliot Glaysher wrote: > > ...
8 years, 3 months ago (2012-09-05 21:38:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10908088/6021
8 years, 3 months ago (2012-09-05 21:44:33 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 00:37:59 UTC) #9 
Change committed as 155073

Powered by Google App Engine
This is Rietveld 408576698