chrome/browser/extensions/api/commands/command_service_factory.h - Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/commands/command_service_factory.h

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_service_factory.cc ('k') | chrome/browser/extensions/api/commands/command_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/commands/command_service_factory.h

===================================================================

--- chrome/browser/extensions/api/commands/command_service_factory.h (revision 154991)

+++ chrome/browser/extensions/api/commands/command_service_factory.h (working copy)

@@ -22,7 +22,7 @@

static CommandServiceFactory* GetInstance();

// Overridden from ProfileKeyedBaseFactory:

- virtual bool ServiceIsCreatedWithProfile() OVERRIDE;

+ virtual bool ServiceIsCreatedWithProfile() const OVERRIDE;

private:

friend struct DefaultSingletonTraits<CommandServiceFactory>;

@@ -33,7 +33,7 @@

// ProfileKeyedServiceFactory:

virtual ProfileKeyedService* BuildServiceInstanceFor(

Profile* profile) const OVERRIDE;

- virtual bool ServiceRedirectedInIncognito() OVERRIDE;

+ virtual bool ServiceRedirectedInIncognito() const OVERRIDE;

DISALLOW_COPY_AND_ASSIGN(CommandServiceFactory);

};