chrome/browser/history/history_service_factory.h - Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/history_service_factory.h

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/google/google_url_tracker_factory.cc ('k') | chrome/browser/history/history_service_factory.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_	5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_

6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_	6 #define CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_

7	7

8 #include "base/memory/singleton.h"	8 #include "base/memory/singleton.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/profiles/refcounted_profile_keyed_service_factory.h"	10 #include "chrome/browser/profiles/refcounted_profile_keyed_service_factory.h"

(...skipping 24 matching lines...) Expand all Loading...
35	35

36 private:	36 private:

37 friend struct DefaultSingletonTraits<HistoryServiceFactory>;	37 friend struct DefaultSingletonTraits<HistoryServiceFactory>;

38	38

39 HistoryServiceFactory();	39 HistoryServiceFactory();

40 virtual ~HistoryServiceFactory();	40 virtual ~HistoryServiceFactory();

41	41

42 // ProfileKeyedServiceFactory:	42 // ProfileKeyedServiceFactory:

43 virtual scoped_refptr<RefcountedProfileKeyedService> BuildServiceInstanceFor(	43 virtual scoped_refptr<RefcountedProfileKeyedService> BuildServiceInstanceFor(

44 Profile* profile) const OVERRIDE;	44 Profile* profile) const OVERRIDE;

45 virtual bool ServiceRedirectedInIncognito() OVERRIDE;	45 virtual bool ServiceRedirectedInIncognito() const OVERRIDE;

46 virtual bool ServiceIsNULLWhileTesting() OVERRIDE;	46 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;

47 };	47 };

48	48

49 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_	49 #endif // CHROME_BROWSER_HISTORY_HISTORY_SERVICE_FACTORY_H_

OLD	NEW