Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/history/history_service_factory.cc

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/history_service_factory.h" 5 #include "chrome/browser/history/history_service_factory.h"
6 6
7 #include "chrome/browser/bookmarks/bookmark_model.h" 7 #include "chrome/browser/bookmarks/bookmark_model.h"
8 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 8 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/history/history.h" 9 #include "chrome/browser/history/history.h"
10 #include "chrome/browser/prefs/pref_service.h" 10 #include "chrome/browser/prefs/pref_service.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 HistoryServiceFactory::BuildServiceInstanceFor(Profile* profile) const { 67 HistoryServiceFactory::BuildServiceInstanceFor(Profile* profile) const {
68 scoped_refptr<HistoryService> history_service( 68 scoped_refptr<HistoryService> history_service(
69 new HistoryService(profile)); 69 new HistoryService(profile));
70 if (!history_service->Init(profile->GetPath(), 70 if (!history_service->Init(profile->GetPath(),
71 BookmarkModelFactory::GetForProfile(profile))) { 71 BookmarkModelFactory::GetForProfile(profile))) {
72 return NULL; 72 return NULL;
73 } 73 }
74 return history_service; 74 return history_service;
75 } 75 }
76 76
77 bool HistoryServiceFactory::ServiceRedirectedInIncognito() { 77 bool HistoryServiceFactory::ServiceRedirectedInIncognito() const {
78 return true; 78 return true;
79 } 79 }
80 80
81 bool HistoryServiceFactory::ServiceIsNULLWhileTesting() { 81 bool HistoryServiceFactory::ServiceIsNULLWhileTesting() const {
82 return true; 82 return true;
83 } 83 }
OLDNEW
« no previous file with comments | « chrome/browser/history/history_service_factory.h ('k') | chrome/browser/history/shortcuts_backend_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698