chrome/browser/history/shortcuts_backend_factory.cc - Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/shortcuts_backend_factory.cc

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/history/shortcuts_backend_factory.h ('k') | chrome/browser/intents/cws_intents_registry_factory.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/history/shortcuts_backend_factory.h"	5 #include "chrome/browser/history/shortcuts_backend_factory.h"

6	6

7 #include "chrome/browser/history/shortcuts_backend.h"	7 #include "chrome/browser/history/shortcuts_backend.h"

8 #include "chrome/browser/prefs/pref_service.h"	8 #include "chrome/browser/prefs/pref_service.h"

9 #include "chrome/browser/profiles/profile_dependency_manager.h"	9 #include "chrome/browser/profiles/profile_dependency_manager.h"

10 #include "chrome/common/pref_names.h"	10 #include "chrome/common/pref_names.h"

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59	59

60 scoped_refptr<RefcountedProfileKeyedService>	60 scoped_refptr<RefcountedProfileKeyedService>

61 ShortcutsBackendFactory::BuildServiceInstanceFor(Profile* profile) const {	61 ShortcutsBackendFactory::BuildServiceInstanceFor(Profile* profile) const {

62 scoped_refptr<history::ShortcutsBackend> backend(	62 scoped_refptr<history::ShortcutsBackend> backend(

63 new ShortcutsBackend(profile, false));	63 new ShortcutsBackend(profile, false));

64 if (backend->Init())	64 if (backend->Init())

65 return backend;	65 return backend;

66 return NULL;	66 return NULL;

67 }	67 }

68	68

69 bool ShortcutsBackendFactory::ServiceIsNULLWhileTesting() {	69 bool ShortcutsBackendFactory::ServiceIsNULLWhileTesting() const {

70 return true;	70 return true;

71 }	71 }

OLD	NEW