Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/custom_handlers/protocol_handler_registry_factory.h

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_ 5 #ifndef CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_
6 #define CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_ 6 #define CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "chrome/browser/profiles/profile_keyed_service_factory.h" 10 #include "chrome/browser/profiles/profile_keyed_service_factory.h"
11 11
12 class Profile; 12 class Profile;
13 class ProtocolHandlerRegistry; 13 class ProtocolHandlerRegistry;
14 template <typename T> struct DefaultSingletonTraits; 14 template <typename T> struct DefaultSingletonTraits;
15 15
16 // Singleton that owns all ProtocolHandlerRegistrys and associates them with 16 // Singleton that owns all ProtocolHandlerRegistrys and associates them with
17 // Profiles. Listens for the Profile's destruction notification and cleans up 17 // Profiles. Listens for the Profile's destruction notification and cleans up
18 // the associated ProtocolHandlerRegistry. 18 // the associated ProtocolHandlerRegistry.
19 class ProtocolHandlerRegistryFactory : public ProfileKeyedServiceFactory { 19 class ProtocolHandlerRegistryFactory : public ProfileKeyedServiceFactory {
20 public: 20 public:
21 // Returns the singleton instance of the ProtocolHandlerRegistryFactory. 21 // Returns the singleton instance of the ProtocolHandlerRegistryFactory.
22 static ProtocolHandlerRegistryFactory* GetInstance(); 22 static ProtocolHandlerRegistryFactory* GetInstance();
23 23
24 // Returns the ProtocolHandlerRegistry that provides intent registration for 24 // Returns the ProtocolHandlerRegistry that provides intent registration for
25 // |profile|. Ownership stays with this factory object. 25 // |profile|. Ownership stays with this factory object.
26 static ProtocolHandlerRegistry* GetForProfile(Profile* profile); 26 static ProtocolHandlerRegistry* GetForProfile(Profile* profile);
27 27
28 protected: 28 protected:
29 // ProfileKeyedServiceFactory implementation. 29 // ProfileKeyedServiceFactory implementation.
30 virtual bool ServiceIsCreatedWithProfile() OVERRIDE; 30 virtual bool ServiceIsCreatedWithProfile() const OVERRIDE;
31 virtual bool ServiceRedirectedInIncognito() OVERRIDE; 31 virtual bool ServiceRedirectedInIncognito() const OVERRIDE;
32 virtual bool ServiceIsNULLWhileTesting() OVERRIDE; 32 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;
33 33
34 private: 34 private:
35 friend struct DefaultSingletonTraits<ProtocolHandlerRegistryFactory>; 35 friend struct DefaultSingletonTraits<ProtocolHandlerRegistryFactory>;
36 36
37 ProtocolHandlerRegistryFactory(); 37 ProtocolHandlerRegistryFactory();
38 virtual ~ProtocolHandlerRegistryFactory(); 38 virtual ~ProtocolHandlerRegistryFactory();
39 39
40 // ProfileKeyedServiceFactory implementation. 40 // ProfileKeyedServiceFactory implementation.
41 virtual ProfileKeyedService* BuildServiceInstanceFor( 41 virtual ProfileKeyedService* BuildServiceInstanceFor(
42 Profile* profile) const OVERRIDE; 42 Profile* profile) const OVERRIDE;
43 43
44 DISALLOW_COPY_AND_ASSIGN(ProtocolHandlerRegistryFactory); 44 DISALLOW_COPY_AND_ASSIGN(ProtocolHandlerRegistryFactory);
45 }; 45 };
46 46
47 #endif // CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_ 47 #endif // CHROME_BROWSER_CUSTOM_HANDLERS_PROTOCOL_HANDLER_REGISTRY_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698