chrome/browser/favicon/favicon_service_factory.cc - Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/favicon_service_factory.cc

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/favicon/favicon_service_factory.h ('k') | chrome/browser/google/google_url_tracker_factory.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/favicon/favicon_service_factory.h"	5 #include "chrome/browser/favicon/favicon_service_factory.h"

6	6

7 #include "base/memory/singleton.h"	7 #include "base/memory/singleton.h"

8 #include "chrome/browser/favicon/favicon_service.h"	8 #include "chrome/browser/favicon/favicon_service.h"

9 #include "chrome/browser/history/history.h"	9 #include "chrome/browser/history/history.h"

10 #include "chrome/browser/history/history_service_factory.h"	10 #include "chrome/browser/history/history_service_factory.h"

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43	43

44 FaviconServiceFactory::~FaviconServiceFactory() {}	44 FaviconServiceFactory::~FaviconServiceFactory() {}

45	45

46 ProfileKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(	46 ProfileKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(

47 Profile* profile) const {	47 Profile* profile) const {

48 HistoryService* history_service = HistoryServiceFactory::GetForProfile(	48 HistoryService* history_service = HistoryServiceFactory::GetForProfile(

49 profile, Profile::EXPLICIT_ACCESS);	49 profile, Profile::EXPLICIT_ACCESS);

50 return new FaviconService(history_service);	50 return new FaviconService(history_service);

51 }	51 }

52	52

53 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() {	53 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {

54 return true;	54 return true;

55 }	55 }

OLD	NEW