chrome/browser/extensions/shell_window_registry.h - Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/shell_window_registry.h

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/extension_system_factory.cc ('k') | chrome/browser/extensions/shell_window_registry.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_	5 #ifndef CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_

6 #define CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_	6 #define CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_

7	7

8 #include <set>	8 #include <set>

9	9

10 #include "base/compiler_specific.h"	10 #include "base/compiler_specific.h"

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 static Factory* GetInstance();	80 static Factory* GetInstance();

81 private:	81 private:

82 friend struct DefaultSingletonTraits<Factory>;	82 friend struct DefaultSingletonTraits<Factory>;

83	83

84 Factory();	84 Factory();

85 virtual ~Factory();	85 virtual ~Factory();

86	86

87 // ProfileKeyedServiceFactory	87 // ProfileKeyedServiceFactory

88 virtual ProfileKeyedService* BuildServiceInstanceFor(	88 virtual ProfileKeyedService* BuildServiceInstanceFor(

89 Profile* profile) const OVERRIDE;	89 Profile* profile) const OVERRIDE;

90 virtual bool ServiceIsCreatedWithProfile() OVERRIDE;	90 virtual bool ServiceIsCreatedWithProfile() const OVERRIDE;

91 virtual bool ServiceIsNULLWhileTesting() OVERRIDE;	91 virtual bool ServiceIsNULLWhileTesting() const OVERRIDE;

92 };	92 };

93	93

94 ShellWindowSet shell_windows_;	94 ShellWindowSet shell_windows_;

95 ObserverList<Observer> observers_;	95 ObserverList<Observer> observers_;

96 };	96 };

97	97

98 } // namespace extensions	98 } // namespace extensions

99	99

100 #endif // CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_	100 #endif // CHROME_BROWSER_EXTENSIONS_SHELL_WINDOW_REGISTRY_H_

OLD	NEW