Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/content_settings/cookie_settings.h

Issue 10908088: Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase, remove a few more lines of code Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_
6 #define CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_ 6 #define CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 static Factory* GetInstance(); 120 static Factory* GetInstance();
121 121
122 private: 122 private:
123 friend struct DefaultSingletonTraits<Factory>; 123 friend struct DefaultSingletonTraits<Factory>;
124 124
125 Factory(); 125 Factory();
126 virtual ~Factory(); 126 virtual ~Factory();
127 127
128 // |ProfileKeyedBaseFactory| methods: 128 // |ProfileKeyedBaseFactory| methods:
129 virtual void RegisterUserPrefs(PrefService* user_prefs) OVERRIDE; 129 virtual void RegisterUserPrefs(PrefService* user_prefs) OVERRIDE;
130 virtual bool ServiceRedirectedInIncognito() OVERRIDE; 130 virtual bool ServiceRedirectedInIncognito() const OVERRIDE;
131 virtual scoped_refptr<RefcountedProfileKeyedService> 131 virtual scoped_refptr<RefcountedProfileKeyedService>
132 BuildServiceInstanceFor(Profile* profile) const OVERRIDE; 132 BuildServiceInstanceFor(Profile* profile) const OVERRIDE;
133 }; 133 };
134 134
135 private: 135 private:
136 virtual ~CookieSettings(); 136 virtual ~CookieSettings();
137 137
138 // Returns true if the "block third party cookies" preference is set. 138 // Returns true if the "block third party cookies" preference is set.
139 // 139 //
140 // This method may be called on any thread. 140 // This method may be called on any thread.
141 bool ShouldBlockThirdPartyCookies() const; 141 bool ShouldBlockThirdPartyCookies() const;
142 142
143 scoped_refptr<HostContentSettingsMap> host_content_settings_map_; 143 scoped_refptr<HostContentSettingsMap> host_content_settings_map_;
144 PrefChangeRegistrar pref_change_registrar_; 144 PrefChangeRegistrar pref_change_registrar_;
145 145
146 // Used around accesses to |block_third_party_cookies_| to guarantee thread 146 // Used around accesses to |block_third_party_cookies_| to guarantee thread
147 // safety. 147 // safety.
148 mutable base::Lock lock_; 148 mutable base::Lock lock_;
149 149
150 bool block_third_party_cookies_; 150 bool block_third_party_cookies_;
151 }; 151 };
152 152
153 #endif // CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_ 153 #endif // CHROME_BROWSER_CONTENT_SETTINGS_COOKIE_SETTINGS_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/gview_request_interceptor_unittest.cc ('k') | chrome/browser/content_settings/cookie_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698