Issue 10824033: Coverity: Fix several pass-by-values.

Issue 10824033: Coverity: Fix several pass-by-values. (Closed)

Created:
8 years, 5 months ago by James Hawkins

Modified:
8 years, 5 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews, michaeln, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fix several pass-by-values. CID_COUNT=8 CID=7757,8647,11476,16931,16932,100206,100577,102872 BUG=none TEST=none R=tbreisacher@chromium.org TBR=brettw@chromium.org,kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148687

Patch Set 1 #

Patch Set 2 : Win build fix. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -16 lines)			Patch
M	chrome/browser/themes/browser_theme_pack.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/url_pattern.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/chrome_process_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/webui/web_ui_message_handler.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/public/browser/web_ui_message_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/renderer_main_platform_delegate_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/win/src/process_thread_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/skia_sandbox_support_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/view_appcache_internals_job.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10824033/1

8 years, 5 months ago (2012-07-26 00:17:13 UTC) #3

commit-bot: I haz the power

8 years, 5 months ago (2012-07-26 00:17:25 UTC) #4

Presubmit check for 10824033-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    sandbox/win/src/process_thread_dispatcher.cc:67

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages