ppapi/native_client/src/trusted/plugin/service_runtime.cc - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc

diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc

index 76fb5789b4794f97717eb5d86b752d9bc9e2fa74..f5311e56a58b67faf1101cc3511fea4c02268ee8 100644

--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc

+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc

@@ -681,7 +681,7 @@ SrpcClient* ServiceRuntime::SetupAppChannel() {

}

-bool ServiceRuntime::Log(int severity, nacl::string msg) {

+bool ServiceRuntime::Log(int severity, const nacl::string& msg) {

NaClSrpcResultCodes rpc_result =

NaClSrpcInvokeBySignature(&command_channel_,

"log:is:",