Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/service_runtime.h

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* -*- c++ -*- */ 1 /* -*- c++ -*- */
2 /* 2 /*
3 * Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 * Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 // A class containing information regarding a socket connection to a 8 // A class containing information regarding a socket connection to a
9 // service runtime instance. 9 // service runtime instance.
10 10
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 // to be started is passed through |nacl_file_desc|. On success, returns 217 // to be started is passed through |nacl_file_desc|. On success, returns
218 // true. On failure, returns false and |error_string| is set to something 218 // true. On failure, returns false and |error_string| is set to something
219 // describing the error. 219 // describing the error.
220 bool Start(nacl::DescWrapper* nacl_file_desc, 220 bool Start(nacl::DescWrapper* nacl_file_desc,
221 ErrorInfo* error_info, 221 ErrorInfo* error_info,
222 const nacl::string& url); 222 const nacl::string& url);
223 223
224 // Starts the application channel to the nexe. 224 // Starts the application channel to the nexe.
225 SrpcClient* SetupAppChannel(); 225 SrpcClient* SetupAppChannel();
226 226
227 bool Log(int severity, nacl::string msg); 227 bool Log(int severity, const nacl::string& msg);
228 Plugin* plugin() const { return plugin_; } 228 Plugin* plugin() const { return plugin_; }
229 void Shutdown(); 229 void Shutdown();
230 230
231 // exit_status is -1 when invalid; when we set it, we will ensure 231 // exit_status is -1 when invalid; when we set it, we will ensure
232 // that it is non-negative (the portion of the exit status from the 232 // that it is non-negative (the portion of the exit status from the
233 // nexe that is transferred is the low 8 bits of the argument to the 233 // nexe that is transferred is the low 8 bits of the argument to the
234 // exit syscall). 234 // exit syscall).
235 int exit_status(); // const, but grabs mutex etc. 235 int exit_status(); // const, but grabs mutex etc.
236 void set_exit_status(int exit_status); 236 void set_exit_status(int exit_status);
237 237
(...skipping 17 matching lines...) Expand all
255 255
256 PluginReverseInterface* rev_interface_; 256 PluginReverseInterface* rev_interface_;
257 257
258 NaClMutex mu_; 258 NaClMutex mu_;
259 int exit_status_; 259 int exit_status_;
260 }; 260 };
261 261
262 } // namespace plugin 262 } // namespace plugin
263 263
264 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_SERVICE_RUNTIME_H_ 264 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_SERVICE_RUNTIME_H_
OLDNEW
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.h ('k') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698