content/public/browser/web_ui_message_handler.h - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_ui_message_handler.h

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/web_ui_message_handler.h

diff --git a/content/public/browser/web_ui_message_handler.h b/content/public/browser/web_ui_message_handler.h

index ab0c8dde728e72ebcb1357c829b2eb7754acf31c..672a8ad9c93301685ca9ba240e938e3c21da8a41 100644

--- a/content/public/browser/web_ui_message_handler.h

+++ b/content/public/browser/web_ui_message_handler.h

@@ -42,7 +42,7 @@ class CONTENT_EXPORT WebUIMessageHandler {

// Adds "url" and "title" keys on incoming dictionary, setting title

// as the url as a fallback on empty title.

static void SetURLAndTitle(base::DictionaryValue* dictionary,

- string16 title,

+ const string16& title,

const GURL& gurl);

// Extract an integer value from a list Value.