chrome/browser/themes/browser_theme_pack.cc - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/browser_theme_pack.cc

diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc

index bf3f74a77f6a6ba2d0011889a38dbc2dfe539384..cb7aba49a21e199e9fd0022c8283dcee01e47e03 100644

--- a/chrome/browser/themes/browser_theme_pack.cc

+++ b/chrome/browser/themes/browser_theme_pack.cc

@@ -377,7 +377,7 @@ scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromExtension(

// static

scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromDataPack(

- FilePath path, const std::string& expected_id) {

+ const FilePath& path, const std::string& expected_id) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

// Allow IO on UI thread due to deep-seated theme design issues.

// (see http://crbug.com/80206)

« no previous file with comments | « chrome/browser/themes/browser_theme_pack.h ('k') | chrome/common/extensions/url_pattern.cc » ('j') | no next file with comments »