sandbox/win/src/process_thread_dispatcher.cc - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/process_thread_dispatcher.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/process_thread_dispatcher.cc

diff --git a/sandbox/win/src/process_thread_dispatcher.cc b/sandbox/win/src/process_thread_dispatcher.cc

index 2df203a682d8f004858e8403e04f5f2776591bf7..b2331b7f525039c52439349858b91bd6b53c0de4 100644

--- a/sandbox/win/src/process_thread_dispatcher.cc

+++ b/sandbox/win/src/process_thread_dispatcher.cc

@@ -64,7 +64,7 @@ bool IsPathRelative(const std::wstring &path) {

}

// Converts a relative path to an absolute path.

-bool ConvertToAbsolutePath(const std::wstring child_current_directory,

+bool ConvertToAbsolutePath(const std::wstring& child_current_directory,

bool use_env_path, std::wstring *path) {

wchar_t file_buffer[MAX_PATH];

wchar_t *file_part = NULL;