chrome/test/base/chrome_process_util.cc - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/chrome_process_util.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/chrome_process_util.cc

diff --git a/chrome/test/base/chrome_process_util.cc b/chrome/test/base/chrome_process_util.cc

index b513c813d83a825f1abf2d19a725f9938f63ae1f..a954f3befa60058a34f47699e5fda237eab78b5b 100644

--- a/chrome/test/base/chrome_process_util.cc

+++ b/chrome/test/base/chrome_process_util.cc

@@ -40,7 +40,7 @@ class ChildProcessFilter : public base::ProcessFilter {

explicit ChildProcessFilter(base::ProcessId parent_pid)

: parent_pids_(&parent_pid, (&parent_pid) + 1) {}

- explicit ChildProcessFilter(std::vector<base::ProcessId> parent_pids)

+ explicit ChildProcessFilter(const std::vector<base::ProcessId>& parent_pids)

: parent_pids_(parent_pids.begin(), parent_pids.end()) {}

virtual bool Includes(const base::ProcessEntry& entry) const {