chrome/common/extensions/url_pattern.cc - Issue 10824033: Coverity: Fix several pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/url_pattern.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win build fix. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/url_pattern.cc

diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc

index c66e780c3bbd3367904d69fab9a39c3610e1221b..34ec6f8d164aaa688f5a69d00e8193fe34f88521 100644

--- a/chrome/common/extensions/url_pattern.cc

+++ b/chrome/common/extensions/url_pattern.cc

@@ -76,7 +76,7 @@ bool IsStandardScheme(const std::string& scheme) {

url_parse::Component(0, static_cast<int>(scheme.length())));

}

-bool IsValidPortForScheme(const std::string scheme, const std::string& port) {

+bool IsValidPortForScheme(const std::string& scheme, const std::string& port) {

if (port == "*")

return true;

« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | chrome/test/base/chrome_process_util.cc » ('j') | no next file with comments »