Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: content/renderer/renderer_main_platform_delegate_win.cc

Issue 10824033: Coverity: Fix several pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win build fix. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/renderer_main_platform_delegate.h" 5 #include "content/renderer/renderer_main_platform_delegate.h"
6 6
7 #include <signal.h> 7 #include <signal.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 if (!::CloseWindowStation(winsta0)) { 58 if (!::CloseWindowStation(winsta0)) {
59 // We might be leaking a winsta0 handle. This is a security risk, but 59 // We might be leaking a winsta0 handle. This is a security risk, but
60 // since we allow fail over to no desktop protection in low memory 60 // since we allow fail over to no desktop protection in low memory
61 // condition, this is not a big risk. 61 // condition, this is not a big risk.
62 NOTREACHED(); 62 NOTREACHED();
63 } 63 }
64 } 64 }
65 } 65 }
66 66
67 // Windows-only skia sandbox support 67 // Windows-only skia sandbox support
68 void SkiaPreCacheFont(LOGFONT logfont) { 68 void SkiaPreCacheFont(const LOGFONT& logfont) {
69 content::RenderThread* render_thread = content::RenderThread::Get(); 69 content::RenderThread* render_thread = content::RenderThread::Get();
70 if (render_thread) { 70 if (render_thread) {
71 render_thread->PreCacheFont(logfont); 71 render_thread->PreCacheFont(logfont);
72 } 72 }
73 } 73 }
74 74
75 void __cdecl ForceCrashOnSigAbort(int) { 75 void __cdecl ForceCrashOnSigAbort(int) {
76 *((int*)0) = 0x1337; 76 *((int*)0) = 0x1337;
77 } 77 }
78 78
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 kRenderTestCall)); 179 kRenderTestCall));
180 DCHECK(run_security_tests); 180 DCHECK(run_security_tests);
181 if (run_security_tests) { 181 if (run_security_tests) {
182 int test_count = 0; 182 int test_count = 0;
183 DVLOG(1) << "Running renderer security tests"; 183 DVLOG(1) << "Running renderer security tests";
184 BOOL result = run_security_tests(&test_count); 184 BOOL result = run_security_tests(&test_count);
185 CHECK(result) << "Test number " << test_count << " has failed."; 185 CHECK(result) << "Test number " << test_count << " has failed.";
186 } 186 }
187 } 187 }
188 } 188 }
OLDNEW
« no previous file with comments | « content/public/browser/web_ui_message_handler.h ('k') | ppapi/native_client/src/trusted/plugin/plugin.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698